feat: cap max invoices per business #1672
Merged
Merged
Conversation
|
@AugistineCreates Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
AugistineCreates
force-pushed
the
feat-invoice-cap
branch
from
6f0a021 to
23b5646
Compare
AugistineCreates
changed the title
Contributor
|
cap max invoices per business — exactly what we wanted. merging 👍 |
5 tasks
Contributor
|
cap max invoices per business — rebased onto main and merged 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr closes #1503
Summary
Implemented a defense‑in‑depth limit on the number of active invoices a business can create. Added a documented constant, exposed a getter, and enforced the cap in
store_invoice. Updated tests with a negative case verifying the limit enforcement.Threat Mitigation
Auditors could flag the absence of a per‑business invoice cap as a potential vector for denial‑of‑service or state‑exhaustion attacks. This change closes that gap by ensuring no business can exceed the configurable maximum, preventing abuse and protecting protocol resources.
Changes
MAX_INVOICES_PER_BUSINESSconstant and getter inprotocol_limits.rs.contract.rsduring invoice storage.test_store_invoice_respects_capintest_max_invoices_per_business.rs.Verification
cargo test -p quicklendx-contracts).cargo clippy -- -D warnings) and formatting (cargo fmt) succeed.